-
Notifications
You must be signed in to change notification settings - Fork 0
Update XLTS for AngularJS #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...S Material to 1.1.29
...ross Linux and macOS
Splaktar
Splaktar
approved these changes
Feb 25, 2022
- use `ionic-v1` only for running the web version - add `@ionic/cli` use it for all Cordova-related commands - update `native-run` - move `cordova` packages to `devDependencies`
Good catch. That was not easy to resolve. I think that it's all working properly now.
Good catch. That was not easy to resolve. I think that it's all working properly now.
👍🏼 Seems to be resolved (I pulled down the commit you made). I thought about digging into it further but didn't want to waste time if it was just me missing something obvious due to lack of knowledge regarding Ionic/Cordova.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Changes
tools/populate-lib.shto work on both Linux and macOS.When the
tools/populate-lib.shfile was invoked on Linux the directory structure would duplicate the last part of the path. For example:...would end up copying files from the source path into
www/lib/angular/angular/instead ofwww/lib/angular/. This article explains the difference in howcp -Rimplementation varies between Linux and macOS. The updated script has been tested to work on both Linux and macOS.Other Notes
I did some quick testing to ensure everything was working and noticed that running any of the following npm scripts seemed to not do anything:
Running any of the above scripts would give the following output:
...which basically indicated that the
ionic-v1cli did understand the arguments. The same output could be produced by running theionic-v1cli without any arguments (./node_modules/.bin/ionic-v1). I'm not very familiar with Ionic or Cordova so I didn't want to spend too much time investigating but thought it would be worthwhile bringing this up in this PR. @Splaktar is there something obvious I'm missing?