Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(npm): warning when run npm install #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Splaktar merged 1 commit into master from fix/playwright-install-warning
Apr 14, 2023

Conversation

Copy link

@jzolnowski jzolnowski commented Mar 26, 2023

Fix the warning from the console
Related to the #11 (comment)

image

Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The commit message header is a bit too long. I would change the commit message to something like:

chore(npm): fix Playwright installation warning

Fix a warning from Playwright when running `npm install`:
> It looks like you are running 'npx playwright install' without first
> installing your project's dependencies.

Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and resolve conflicts.

...all without first installing your project's dependencies' when run npm install
@jzolnowski jzolnowski force-pushed the fix/playwright-install-warning branch from 997f45a to b2183ca Compare March 31, 2023 13:34
Copy link
Author

Branch up-to-date with master

@Splaktar Splaktar merged commit 21eef89 into master Apr 14, 2023
@Splaktar Splaktar deleted the fix/playwright-install-warning branch April 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkalpak gkalpak gkalpak approved these changes

+1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /