-
Notifications
You must be signed in to change notification settings - Fork 18
Remove dark-theme hack given upstream fix#94
Draft
jthielen wants to merge 4 commits intoxarray-contrib:main from
Draft
Remove dark-theme hack given upstream fix #94jthielen wants to merge 4 commits intoxarray-contrib:main from
jthielen wants to merge 4 commits intoxarray-contrib:main from
Conversation
@jthielen
jthielen
added
the
documentation
Improvements or additions to documentation
label
Sep 9, 2022
Collaborator
Author
jthielen
commented
Sep 9, 2022
Member
andersy005
commented
Sep 9, 2022
I don't notice this issue with the existing hack. Does anyone else have this same issue?
i can confirm that i'm noticing the same issue (on MacOS, Safari)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Simply implements the changes suggested in #74! Did not test locally; hoping that CI will do the trick.
Related issue number
Closes #74.
Checklist
(削除) Unit tests for the changes exist (削除ここまで)(削除) Documentation reflects the changes where applicable (削除ここまで)