-
Notifications
You must be signed in to change notification settings - Fork 29
Comments
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for xarraydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
for more information, see https://pre-commit.ci
15e9d54 to
12b1737
Compare
@keewis
keewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, Scott, that was a nice read.
I didn't check how this looks, but from the markdown at least this looks good to me in general. I do have a few comments on the details, though.
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
scottyhq
commented
Aug 25, 2025
I left a few pretty minor suggestions. Let's get this out next week!
Thanks, publishing this week sounds good to me! I added your suggestions and went over one more time with a few tweaks. @benbovy do you have time this week to have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @scottyhq for putting this together! And sorry for the late review.
Overall this looks great! I added a few comments, mostly nit picking.
src/posts/flexible-indexing/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottyhq since you authored this blog post I think it would make sense to add you as 1st author here, or at least add something that gives you credit for authoring this post.
I'm thinking of authoring a follow-up technical blog post on how to customize Xarray's behavior via indexes for common operations such as assigning, indexing and alignment (with flowcharts illustrating the logic of Xarray internals and how the index API is called).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, either way is fine by me. want to make sure you're recognized as leading the effort overall!
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
scottyhq
commented
Sep 2, 2025
Thanks for the review @benbovy I've incorporated all your feedback. I'm going to go ahead and merge it in, thanks again everyone for helping with this!
the only thing we forgot to do is update the blog post release date: right now it says "23 days ago"
Supercedes #597