-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Conversation
qnighy
commented
Nov 6, 2023
Collaborator
Author
@izumin5210 could you look at this?
qnighy
commented
Nov 11, 2023
Collaborator
Author
@izumin5210 We have been extensively using izumin5210/gex and izumin5210/grapi and want to have these packages up-to-date with the current state of the ecosystem. You know we have currently submitted three: this PR, #71, and #72.
We are willing to continue contributing the patches if needed, but we cannot merge them ourselves. We need your help.
I understand you are busy and probably aren't as interested in it as before anymore. If you cannot afford time or other resources to review them, we are prepared to propose these alternatives:
- to inherit the modules' ownerships and help maintain them, if you are willing to give us ones
- or to fork them ourselves.
I'd appreciate it if I could hear your thoughts on it. Thank you in advance!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.17 introduced a new format for build tags, namely
//go:build. This PR incorporates the change so that the build tag is written in both formats. This is how go fmt updates the existing code.https://pkg.go.dev/cmd/go#hdr-Build_constraints