-
Notifications
You must be signed in to change notification settings - Fork 0
feat(catalog): expose localized parameter spellings - #176
Conversation
@Teakowa
Teakowa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two required fixes before merge:
crates/workshop-rs/src/catalog/data/catalog.json: this adds semantic catalog data (paramAliases) but only refreshes the digest.docs/provenance.mddefinescatalog-versionas bumped by any dataset change, so bump the dataset version together with this change.docs/provenance.md/catalog.json: the new zh-CN parameter labels are described only as "owner-reviewed", while this document requires committed mapping data to record its source evidence and later states that all committed zh-CN spellings come from JSON evidence through the corpus pipeline. Record the actual evidence/provenance for these parameter labels (and align the locale statement/pipeline if they are sourced differently) rather than committing an unevidenced canonical mapping.
e54-bot
commented
Sep 11, 2026
Addressed the requested owner-side corrections in 46e27e1: bumped the catalog dataset version from 0.1.3 to 0.1.4 and refreshed the digest; documented the Wait parameter-label provenance separately from the general zh-CN corpus pipeline, including the pinned workshop-data source, the Chinese Workshop reference, access date, and documented-community-evidence status. Local fmt, clippy, full workspace tests, catalog check, and diff validation pass.
@Teakowa
Teakowa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crates/workshop-rs/src/catalog/data/catalog.json / docs/provenance.md: the catalog-version finding is fixed, but the parameter-label provenance is still not sufficient for the committed 持续时间 spelling. The newly cited Chinese Workshop reference does not establish that label; the accessible Chinese Workshop documentation for Wait identifies the first parameter as 时间 (and the second as 等待行为). Either use the evidenced client spelling or cite direct evidence that the supported Workshop locale actually exposes 持续时间 for this parameter. The owner catalog should not canonicalize a localized parameter label that its recorded source does not support.
e54-bot
commented
Sep 11, 2026
Addressed the latest review in 260c496: replaced the unsupported Wait parameter alias with the evidenced client spelling ; remains the second parameter. Updated the catalog dataset version to 0.1.5 and refreshed the digest/pin. The provenance text now records both exact zh-CN spellings and their documented Chinese Workshop reference. Local fmt, clippy, full workspace tests, catalog check, and diff validation pass.
e54-bot
commented
Sep 11, 2026
Correction to the previous note: the exact change was to replace the unsupported Wait parameter alias 持续时间 with the evidenced client spelling 时间; 等待行为 remains the second parameter. The commit is 260c496.
260c496 to
7a28676
Compare
Adds owner-backed parameter locale metadata to the Workshop catalog. CatalogEntry::resolve_param resolves canonical and reviewed localized spellings by declared parameter position, with validation and coverage tests for Wait in zh-CN. This is the dependency contract for wrightkit/wright#310.