-
-
Notifications
You must be signed in to change notification settings - Fork 90
libworkbench: implement GLogWriterFunc and library initialization #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
sonnyp
reviewed
Aug 20, 2023
Contributor
@sonnyp
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the rational / benefit of this in the PR description?
@andyholmes
andyholmes
force-pushed
the
andyholmes/libworkbench
branch
4 times, most recently
from
August 20, 2023 22:05
34287c9 to
71c18cb
Compare
Add `Workbench.init()` to initialize resources and other setup tasks. Currently, this only implements a `GLogWriterFunc` for silencing specific messages that Workbench users shouldn't see. This method has some limitations running on other threads in GJS, and should be more performant in C anyways.
@andyholmes
andyholmes
force-pushed
the
andyholmes/libworkbench
branch
from
August 20, 2023 22:16
71c18cb to
eae9ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Add
Workbench.init()to initialize resources and other setup tasks.Currently, this only implements a
GLogWriterFuncfor silencingspecific messages that Workbench users shouldn't see.
This method has some limitations running on other threads in GJS,
and should be more performant in C anyways.