-
Notifications
You must be signed in to change notification settings - Fork 110
Allow custom headers to be specified for all api requests #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benje
commented
Aug 6, 2021
I also need this functionality and @fatboystring's solution looks great!
HubertGL
commented
Nov 5, 2022
this could also solve the problem with the X-HTTP-Method-Override header indirectly if http methods are limited to only GET and POST for security reasons. But this feature might be easier implemented as separated feature within the __request() method to only change the init method and not each put and delete for the clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the library. I have an issue where a third party woocommerce api I interact with implements caching, but I always need the most up-to-date version of the data when I call the api.
I am able to bust the cache using a custom query parameter with a timestamp but this feels hacky. The third party api does respect the
cache-controlheader and it seems generally useful to be able to specify custom headers to send with every request.I'm hoping you'd be open to merging and releasing the changes in this PR. Please do let me know if you would like me to make any further changes, happy to help.
Thanks in advance