-
Notifications
You must be signed in to change notification settings - Fork 110
Updated standards and fixed problems with python 3.8 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Evert-Arends
Evert-Arends
commented
Oct 6, 2020
- Updated version
- Removed percentage operator in favor of f-strings
- Added HTTPBasicAuth to auth for stricter reading
- Removed python from HTTPBasicAuth header, to make this API work with the latest version of python.
- Updated version - Removed percentage operator in favor of f-strings - Added HTTPBasicAuth to auth for stricter reading - Removed python from HTTPBasicAuth header, to make this API work with the latest version of python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like unit test aren't working anymore for older versions of Python.
Still not sure if we could drop support for those.
Thanks for your help.
I do think support for python2.7 should be dropped, as python2.7 is not supported anymore.
However for python 3.5 this could be used: https://stackoverflow.com/questions/55182209/f-string-invalid-syntax-in-python-3-5
You could technically remove the fstring for string format, but that is less future proof.
Thanks for taking a look at this.
Best regards
@Evert-Arends I agree with you, let's set only what is currently supported by Python only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help, and for inspiring me to drop support to older Python versions.
Thanks for merging, much appreciated!