-
Notifications
You must be signed in to change notification settings - Fork 37
Validate DH peer public key subgroup before key agreement - #460
Validate DH peer public key subgroup before key agreement #460aidangarske wants to merge 4 commits into
Conversation
@aidangarske
aidangarske
commented
Aug 6, 2026
@wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fenrir Automated Review — PR #460
Scan targets checked: wolfprovider-bugs, wolfprovider-src
Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fenrir Automated Review — PR #460
Scan targets checked: wolfprovider-bugs, wolfprovider-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we only test if set_peer succeeds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the empty trailing line is dropped. Can we keep it?