This repository was archived by the owner on Oct 11, 2022. It is now read-only.
forked from ngs/draft-js-markdown-shortcuts-plugin
-
Notifications
You must be signed in to change notification settings - Fork 37
Allow custom inline style matcher #94
Open
dino115
wants to merge
8
commits into
withspectrum:master
from
dino115:feature/customInlineStyleMatchers
Open
Allow custom inline style matcher #94
dino115
wants to merge
8
commits into
withspectrum:master
from
dino115:feature/customInlineStyleMatchers
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: I've added the ability to wait for a whitespace character after the markdown applies a style to the text. To use this, you have to group the ending whitespace in the regular expression.
This is neccessary if you will use the same char in different styles. I.e. ** for bold and * for italic.
BOLD: [/\*\*(.+)\*\*(\s)$/g], ITALIC: [/\*(.+)\*(\s)$/g],
@dino115
dino115
force-pushed
the
feature/customInlineStyleMatchers
branch
from
June 25, 2018 15:18
61e835b to
2350fb0
Compare
@dino115
dino115
force-pushed
the
feature/customInlineStyleMatchers
branch
from
June 25, 2018 16:24
2350fb0 to
60407de
Compare
mxstbr
commented
Jul 5, 2018
Sorry for the slow response here—I see where you're going with this and why it'd be use, but I'm not sure I'm ready to maintain all this code we don't use 😕 I'm afraid it'll grow stale and buggy, and it won't be a good experience.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, thank you very much for your great work!
For my project i have to change the inline style handlers, because up to now we have used a slightly different markdown syntax. I.e.
**for bold,*for italic, and_for underline and i have to add some additional inline styles.So i quickly added a configuration for custom inline style matchers. You can use it in the following way:
What do you think about this?