-
-
Notifications
You must be signed in to change notification settings - Fork 232
Added expand/collapse functionalities to relationship formwidget #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bennothommo
commented
Jun 25, 2025
@damsfx ooo, I like this. And in Snowboard too! 😍
Couple of quick comments/questions:
- How performant is it with a whole heap of items (like, say, 100s of items)?
- Could the animation be a touch faster? Might be just on the border of being a bit too slow to feel "snappy".
And in Snowboard too! 😍
Definitely yes!
The more I practice, the more I love it! It's good to be back in a vanilla javascript environment.
Despite this, a function written in jQuery is still called to update the scroll bar. :o(
How performant is it with a whole heap of items (like, say, 100s of items)?
The tree structure used for my tests and visible in the animation above contains 550 nodes spread over 4 levels of depth.
I can always do a test with more nodes.
Could the animation be a touch faster? Might be just on the border of being a bit too slow to feel "snappy".
For sure.
damsfx
commented
Jun 27, 2025
Latest update :
- Use promise to adjust srcollbar after expand/collaspe node(s)
- CloseAll() close only opened nodes instead of all nodes
- Reduce animation timmings
- Use CSS animation end to trigger scrollbar update
bennothommo
commented
Jun 27, 2025
@damsfx don't be too concerned if you need to fall back on jQuery to do something in the Backend. A lot of the Backend still uses it and the goal of Snowboard was to remove the dependency of jQuery for the CMS side in particular.
LukeTowers
commented
Jul 16, 2025
@bennothommo are you happy with this as it is?
@damsfx is there a related docs PR?
damsfx
commented
Jul 16, 2025
@damsfx is there a related docs PR?
Not yet, but I can add a pending PR for this.
Co-authored-by: Luke Towers <github@luketowers.ca>
@damsfx is there a related docs PR?
@LukeTowers Done : wintercms/docs#243
damsfx
commented
Sep 5, 2025
@bennothommo I know your time is precious, but if you have 5 mins to take a look and give me a little feedback if you see any improvements to be made.
Thank you for your time.
bennothommo
commented
Sep 9, 2025
@damsfx sorry for the delay. Looks great, and the timing of the animation is much better.
Only issue I can see now is that it appears that some plugins and themes were added in your most recent commit:
90fbd40
Could you make sure these are not included in your branch? Once that's done, @LukeTowers should be able to merge if he's happy with it.
@bennothommo
bennothommo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending removal of plugins and themes in recent commit
pending removal of plugins and themes in recent commit
😱🙄 Oh, I was really distracted!
Thanks for reminding me.
Done !
This allow relation model with nested tree trait to display a expandable/collapsable list of checkboxes.
relation_with_tree
The field config allow two new options :