-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix agent modal scrolling and add edit functionality #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+80
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed overflow-hidden to min-h-0 in AgentsModal to enable proper scrolling - Added max-h constraint and overflow-y-scroll to agent list container - Removed conflicting height constraints that prevented scrolling - Now all agents are visible with proper scrollbar functionality Fixes issue where users couldn't see all their agents in the modal
- Added Edit button to each agent in the Agent Management modal - Implemented event system to pass agent data to CreateAgent component - Modified CreateAgent to accept editing data from localStorage - Added proper cleanup of localStorage after editing Closes winfunc#259 - Users can now edit existing agents
Member
123vivekr
commented
Oct 10, 2025
@claude please review this
Claude encountered an error —— View job
Failed with exit code 128
I'll analyze this and get back to you.
Member
123vivekr
commented
Oct 10, 2025
@claude please review this
Claude encountered an error —— View job
Failed with exit code 128
I'll analyze this and get back to you.
Member
123vivekr
commented
Oct 10, 2025
Hi, thanks for the PR. I just ran it through claude. Can you take a look at these suggestions?
-
Remove localStorage, use React Context or Props
// Better approach: Use a shared context or props interface EditAgentContextType { editingAgent: Agent | null; setEditingAgent: (agent: Agent | null) => void; } const EditAgentContext = createContext<EditAgentContextType>(/* ... */);
-
Add Error Handling
// Wrap JSON.parse in try-catch try { const stored = window.localStorage.getItem('editingAgent'); if (stored) { return JSON.parse(stored); } } catch (error) { console.error('Failed to parse editing agent data:', error); // Clear corrupted data window.localStorage.removeItem('editingAgent'); }
-
Remove Arbitrary Timeouts
- Use proper React lifecycle methods instead of setTimeout
- If tab update is async, use callbacks or promises
-
Type Custom Events
// Create typed event definitions interface OpenEditAgentTabEvent extends CustomEvent { detail: { agent: Agent; }; } declare global { interface WindowEventMap { 'open-edit-agent-tab': OpenEditAgentTabEvent; } }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues with the Agent Management modal:
Changes Made
1. Fixed Agent Modal Scrolling
ScrollAreacomponent with nativeoverflow-y-scrollinAgentsModal.tsxoverflow-hiddentomin-h-0to allow proper scrollingmax-h-[400px]constraint to ensure scrollbar appears2. Added Edit Functionality
Testing