Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

update picker #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruoru wants to merge 1 commit into weui:master
base: master
Choose a base branch
Loading
from ruoru:update/picker
Open

update picker #219

ruoru wants to merge 1 commit into weui:master from ruoru:update/picker

Conversation

@ruoru
Copy link

@ruoru ruoru commented Mar 22, 2017
edited
Loading

issue #218

Copy link

Coverage Status

Coverage increased (+6.5%) to 88.564% when pulling b58a43d on ruoru:update/picker into 01bc1c5 on weui:master.

Copy link

Coverage Status

Coverage increased (+6.5%) to 88.574% when pulling 1148af5 on ruoru:update/picker into 01bc1c5 on weui:master.

Copy link
Author

ruoru commented Jan 16, 2018
edited
Loading

Sorry, this branch is too long, I am more lazy :), oh, this repo have not update for six months, I will rebase and to solve #218, maybe some question are solved.

Copy link

coveralls commented Jan 16, 2018
edited
Loading

Coverage Status

Coverage decreased (-7.2%) to 74.306% when pulling 06eac4f on ruoru:update/picker into f8b12cd on weui:master.

@ruoru ruoru changed the title (削除) 优化picker_group (削除ここまで) (追記) update picker_group (追記ここまで) Jan 16, 2018
@ruoru ruoru changed the title (削除) update picker_group (削除ここまで) (追記) update picker (追記ここまで) Jan 16, 2018
Copy link
Author

ruoru commented Jan 16, 2018
edited
Loading

when i merge 1.1.3 and install package start, there are some error:

npm WARN deprecated babel@6.23.0: In 6.x, the babel package has been deprecated in favor of babel-cli. Check https://opencollective.com/babel to support the Babel maintainers
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN react-weui@1.1.3 requires a peer of react@0.14.x || ^15.0.0-0 || 15.x but none is installed. You must install peer dependencies yourself.
npm WARN react-weui@1.1.3 requires a peer of react-dom@^0.14.x || ^15.0.0-0 || 15.x but none is installed. You must install peer dependencies yourself.
npm WARN babel-loader@6.4.1 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN enzyme@2.7.1 requires a peer of react@0.13.x || 0.14.x || ^15.0.0-0 || 15.x but none is installed. You must install peer dependencies yourself.
npm WARN html-webpack-plugin@2.28.0 requires a peer of webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN react-addons-test-utils@15.4.2 requires a peer of react-dom@^15.4.2 but none is installed. You must install peer dependencies yourself.
npm WARN react-codemirror@0.2.6 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-fontawesome@1.5.0 requires a peer of react@>=0.12.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-router@4.2.0 requires a peer of react@>=15 but none is installed. You must install peer dependencies yourself.
npm WARN react-router-dom@4.2.2 requires a peer of react@>=15 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@2.2.1 requires a peer of react@>=15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@2.2.1 requires a peer of react-dom@>=15.0.0 but none is installed. You must install peer dependencies yourself.

now i can not run well, maybe fix this problem will run well.

this issue solved in #258

@ruoru ruoru force-pushed the update/picker branch 2 times, most recently from f623fc3 to ea8c656 Compare January 27, 2018 10:32
@ruoru ruoru force-pushed the update/picker branch 2 times, most recently from 0d9b205 to 8af2426 Compare February 5, 2018 03:49
Copy link
Author

ruoru commented Feb 5, 2018
edited
Loading

i am already fix it and please review it, If there is no problem I hope to merge it. @weui

@ruoru ruoru force-pushed the update/picker branch 2 times, most recently from 3ae76c0 to 98dbaa3 Compare February 5, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n7best n7best Awaiting requested review from n7best

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /