-
Notifications
You must be signed in to change notification settings - Fork 248
Open
Conversation
CLA assistant check
All committers have signed the CLA.
wj-Mcat
wj-Mcat
requested changes
Jul 12, 2021
@wj-Mcat
wj-Mcat
left a comment
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You find the problem:
Calling msg.say(hd_file_box) will report an error `Wechaty - ERROR - internal error <'utf-8' codec can't decode byte 0xff in position 0: invalid start byte>`, but reading the image from local file will fix it.
Also, added an example to the reply URL, vaild for WeChat articles.
Can you find the reason of this problem or post another pr to fix it ? Hoping your futher work.
huan
commented
Jul 12, 2021
Member
Link to wechaty/PMC#16
wj-Mcat
wj-Mcat
requested changes
Jul 17, 2021
@wj-Mcat
wj-Mcat
left a comment
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many strict code style, which is crucial for wechaty opensource community.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling msg.say(hd_file_box) will report an error
Wechaty - ERROR - internal error <'utf-8' codec can't decode byte 0xff in position 0: invalid start byte>, but reading the image from local file will fix it.Also, added an example to the reply URL, vaild for WeChat articles.