-
-
Notifications
You must be signed in to change notification settings - Fork 73
Add offline mode to skip tests that require an internet connection - #135
Open
Luflosi wants to merge 1 commit into
Open
Add offline mode to skip tests that require an internet connection #135Luflosi wants to merge 1 commit into
Luflosi wants to merge 1 commit into
Conversation
ikreymer
commented
Oct 5, 2021
Member
Thanks! I think that looks reasonable, and actually instead of pytest.ini, you can just add it to conftest.py so its all in one place. I think the following should work:
def pytest_configure(config):
config.addinivalue_line(
"markers", "online: marks tests as requiring an internet connection"
)
Luflosi
marked this pull request as ready for review
October 6, 2021 08:55
Luflosi
commented
Oct 6, 2021
Author
Yes, that works, thanks. Please review.
12 tasks
Luflosi
commented
Nov 11, 2021
Author
Do you maybe have some time to review this please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133.
I found a way to make make skipping the tests very elegant, requiring only
@mark.online().This comes at the expense of a little more code in
conftest.py, the use of theget_closest_marker()function, which seems a bit hacky IMO and the additional filepytest.iniat the root of the project which registers the custom mark to avoid a warning.If you think this is not worth it, I can just change this PR to skip the tests like in the APIO example.
I marked this PR as a draft to better indicate that I need your opinion on how to do this.