-
-
Notifications
You must be signed in to change notification settings - Fork 239
Open
Conversation
url_post is the original url with the POST data extracted from the urlkey and appended as query parameter. Use with outbackcdx instead of url parameter.
ikreymer
commented
Dec 8, 2020
Member
Thanks for adding this! Since OutbackCDX now supports __wb_post_data, I wonder if it would make sense to simply use that parameter to keep it simpler to maintain? For example, maybe JSON data could be prefixed with __wb_post_data=json:...?
And yes, would be very helpful to have some tests, let me know if you need any questions on where to add them!
Codecov Report
@@ Coverage Diff @@ ## master #587 +/- ## ========================================== - Coverage 87.69% 87.11% -0.58% ========================================== Files 64 64 Lines 8096 8113 +17 Branches 1445 1447 +2 ========================================== - Hits 7100 7068 -32 - Misses 640 675 +35 - Partials 356 370 +14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change provides a new parameter
url_postto the template used to configure a remote index source. Theurl_postparameter includes the original url with POST data appended as, if available. The parameter__wb_post_datais extracted from the final url key.Motivation and Context
This resolves a problem with communicating POST parameters to OutbackCDX. It fixes a replay issue described in #585. OutbackCDX has in the meantime been extended to index POST parameters as described in nla/outbackcdx#91. A sample config.yaml for OutbackCDX looks like this:
I first tried using the existing
alt_url. However, the alt_url is based on the original (unfiltered) url and it is not available for all calls. In order not to break existing solutions, I propose to use this new parameter.Types of changes
Checklist:
Still missing: tests (work in progress), documentation updates. Feedback and discussion welcome!