-
-
Notifications
You must be signed in to change notification settings - Fork 239
Open
Conversation
ikreymer
commented
Oct 18, 2020
Member
Thanks for the PR!
This is not a common use case, but good to have it supported for your workflow!
It looks like the tests are failing with this change so far: https://travis-ci.com/github/webrecorder/pywb/jobs/400118397
Could you take a look, and perhaps also add a test for surt_ordered: false with a small cdx?
Let me know if you have any questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: