-
Notifications
You must be signed in to change notification settings - Fork 4
Consider changing Composer package type to "phpcodesniffer-standard" - #3
Open
rodrigoprimo wants to merge 1 commit into
Open
Consider changing Composer package type to "phpcodesniffer-standard" #3rodrigoprimo wants to merge 1 commit into
rodrigoprimo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests changing the Composer package type to enable automatic standard registration via the PHPCSStandards Composer installer plugin.
Problem/Motivation
Composer allows declaring a package's type. This package currently uses
"library"as its type.There is a Composer plugin that can install custom PHP_CodeSniffer standards: https://github.com/PHPCSStandards/composer-installer
This plugin is part of the PHPCSStandards organisation, which is the new official home of PHP_CodeSniffer.
For this installer to work, the package type needs to be set to
phpcodesniffer-standard.There are already over 470 packages that use this type. As a side benefit, using this type will allow end-users to more easily find other external PHP_CodeSniffer standards that may be interesting to them when searching on Packagist.
Proposed changes
Change the
typeincomposer.jsonfrom"library"to"phpcodesniffer-standard".This will in no way change the existing behavior of this package for users that do not include the Composer plugin mentioned above in their projects'
composer.json.