Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

docs(Configuration): fix document amdContainer #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenxsan merged 6 commits into webpack:main from long76:patch-1
Apr 18, 2023
Merged

Conversation

Copy link
Contributor

@long76 long76 commented Apr 8, 2023 •
edited
Loading

Fix amdContainer description

Copy link

vercel bot commented Apr 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 2:06am

@long76 long76 changed the title (削除) Patch 1 (削除ここまで) (追記) docs(Configuration): fix document amdContainer (追記ここまで) Apr 8, 2023
Copy link
Member

chenxsan commented Apr 8, 2023

@TheLarkInn @alexander-akait Hey guys, it would be great if you could help review this pull request. I realized that I may have misunderstood something based on this comment: #6742 (comment).

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few small wording changes and LGTM!

 

Co-authored-by: Sean Larkin <sean.larkin1@gmail.com>
Copy link
Member

You can merge as you see fit @chenxsan. Thank you for the ping!

@chenxsan chenxsan merged commit f980d23 into webpack:main Apr 18, 2023
@long76 long76 deleted the patch-1 branch April 18, 2023 04:45
Copy link
Contributor Author

long76 commented Apr 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLarkInn TheLarkInn TheLarkInn approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /