Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

docs(Configuration): fix lang for code block #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenxsan merged 1 commit into webpack:master from chenxsan:bugfix/fix-lang
Oct 16, 2022

Conversation

Copy link
Member

@chenxsan chenxsan commented Oct 16, 2022 •
edited
Loading

There's no console language for code block https://github.com/wooorm/refractor#data

Copy link

vercel bot commented Oct 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Oct 16, 2022 at 2:04AM (UTC)

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we throw lint errors for such errors?

Copy link
Member Author

LGTM. Can we throw lint errors for such errors?

Really good idea. There's a rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md040 requiring us to specify a language for code block, unfortunately we can't specify which languages to be included. But I think it could be feasible with a custom rule. I'll try it later.
snitin315 reacted with thumbs up emoji

@chenxsan chenxsan merged commit 63bb67f into webpack:master Oct 16, 2022
@chenxsan chenxsan deleted the bugfix/fix-lang branch October 16, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /