Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(docs): improves URL macros in README.md #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EugeneHlushko merged 2 commits into webpack:master from pranshuchittora:refactor-docs
May 14, 2019

Conversation

Copy link
Member

@pranshuchittora pranshuchittora commented May 13, 2019

Improved URL macros in README.md

Copy link

netlify bot commented May 13, 2019
edited
Loading

README.md Outdated
- [Guides - Review and Simplify][1]
- [Concepts - Review and Organize][2]
- [API - v4 Rewrite][8]
- [Guides - Review and Simplify][issue-1258]
Copy link
Member

@montogeek montogeek May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use numbers instead of guides, concepts, api like you did in the rest of the references?

EugeneHlushko reacted with thumbs up emoji
Copy link
Member Author

@pranshuchittora pranshuchittora May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure between this & issue number.
Will change it 👍

montogeek reacted with thumbs up emoji
Copy link
Member Author

@pranshuchittora pranshuchittora May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@montogeek pls review the new changes.

Thank you

@EugeneHlushko EugeneHlushko merged commit 956cfab into webpack:master May 14, 2019
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek left review comments

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

+1 more reviewer

@anshumanv anshumanv anshumanv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /