@theEquinoxDev thanks! The disabled option isn't really different enough from the available one, at least in the screenshot you gave. Can you check that?

Thanks for the feedback!
I agree, the disabled state might not be distinct enough from the enabled one. I'll tweak it further and and make it more clearly differentiated and update the PR with new screenshots.

I updated the disabled styling to make it more visually distinct and replaced the screenshots with the latest version. Could you please take another look?

Ah sorry, were the menu buttons always disabled? I thought that some parts of the menu would be clickable while others weren't but was it so that all these menu buttons in your screenshots have always been disabled?

You could use some a11y contrast tool, maybe Silktide https://silktide.com/toolbar/ or the browser native color contrast tools to verify if they have at least 4.5:1 color contrast to be readable enough.

Thanks for checking! from what i noticed, these buttons were always disabled. I tried clicking them, but it was disabled from the start.
I'll also run the colors through a contrast checker as suggested and report back if any adjustments seems necessary.

Huh... I wonder how this feature used to work. Maybe it was tied to the checkboxes in the side navigation somehow? 😅

I haven't touched the enable/disable logic at all, only the styling.
From my testing, the options shown in the screenshots are disabled based on the current selection state, and I wasn't able to find a scenario where those particular items become enabled.
It's possible they were intended to be tied more closely to sidebar selection or checkboxes earlier on, but I didn’t dig into historical behavior beyond what;s currently observable.
Though, if you could guide me, I can take a look upon this. let me know what exactly do i need to check.

I checked the contrast using the browser contrast tools and it says - the disabled menu items have a contrast ratio of 6.37:1,

From an accessibility standpoint this should be readable enough but if you'd still prefer the disabled state to be visually more emphasized beyond that, I'm happy to adjust the styling further. I've also attached the screenshot of the contrast ratio. you can have a look at that.

Just a quick follow-up on this - I verified the contrast (6.37:1, WCAG AA) and updated the screenshots accordingly.
Let me know if this looks good to you or if you'd prefer the disabled state to be emphasized more. Happy to adjust either way

Ok thanks! I'll get back to this PR after the rest of the refactoring pull requests we're currently doing in this repository are over.

Sounds good, thanks for the update! I'll wait until the refactoring PRs are done.😊

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.35%. Comparing base (2588e54) to head (4620cc5).

@@ Coverage Diff @@
## main #690 +/- ##
=======================================
 Coverage 70.35% 70.35% 
=======================================
 Files 17 17 
 Lines 914 914 
 Branches 308 308 
=======================================
 Hits 643 643 
 Misses 238 238 
 Partials 33 33 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.