-
Notifications
You must be signed in to change notification settings - Fork 12
fix - changing percentage to mod #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Imran-imtiaz48
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
- Body Element Modification:
o Old Code: Uses without an id attribute.
o New Code: Adds id="container" to . - Style Changes:
o Old Code: Uses color: blue forelement style.
o New Code: Changeselement to use color: rgb(225 202 22) and
element to use color: black.
Improvements Needed - Semantic HTML:
o Ensure that the id="container" on is necessary and used consistently throughout the JavaScript code or CSS styling. - CSS Management:
o Consider moving the style definitions (color: rgb(225 202 22) and color: black) to a separate CSS file or <style> block for better maintainability and separation of concerns. - Accessibility:
o Verify that the chosen colors meet accessibility standards, especially for text readability and contrast against background colors. - Copyright Notice:
o Ensure that the copyright notice (Copyright 2020 | Designed & Developed by Devanshu Vashishtha | All Rights Reserved.) is accurate and up-to-date.
Summary
The changes primarily involve adding an id attribute to the element and updating styles for theand
elements. Ensure that these changes align with the overall design and functionality requirements of the JavaScript calculator application, maintain accessibility standards, and are well-documented for future maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esto arregla el Issue.