Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix - changing percentage to mod #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremias-cuello wants to merge 2 commits into web-codegrammer:master
base: master
Choose a base branch
Loading
from jeremias-cuello:master

Conversation

Copy link

@jeremias-cuello jeremias-cuello commented Feb 5, 2024

Esto arregla el Issue.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

  1. Body Element Modification:
    o Old Code: Uses without an id attribute.
    o New Code: Adds id="container" to .
  2. Style Changes:
    o Old Code: Uses color: blue for
    element style.
    o New Code: Changes
    element to use color: rgb(225 202 22) and

    element to use color: black.
    Improvements Needed

  3. Semantic HTML:
    o Ensure that the id="container" on is necessary and used consistently throughout the JavaScript code or CSS styling.
  4. CSS Management:
    o Consider moving the style definitions (color: rgb(225 202 22) and color: black) to a separate CSS file or <style> block for better maintainability and separation of concerns.
  5. Accessibility:
    o Verify that the chosen colors meet accessibility standards, especially for text readability and contrast against background colors.
  6. Copyright Notice:
    o Ensure that the copyright notice (Copyright 2020 | Designed & Developed by Devanshu Vashishtha | All Rights Reserved.) is accurate and up-to-date.
    Summary
    The changes primarily involve adding an id attribute to the element and updating styles for the
    and

    elements. Ensure that these changes align with the overall design and functionality requirements of the JavaScript calculator application, maintain accessibility standards, and are well-documented for future maintenance.

jeremias-cuello reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Imran-imtiaz48 Imran-imtiaz48 Imran-imtiaz48 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /