This repository was archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 274
Open
Conversation
coveralls
commented
Dec 21, 2019
JasperDeSutter
commented
Dec 21, 2019
Author
I tried including the wasm file in the latest commit instead of the rust source code. It is available here: https://github.com/rust-analyzer/rust-analyzer.github.io/tree/master (passed through wasm-opt to reduce size to 2.7MB instead of 5+)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #50
Summary of Changes
things like go-to definition, find usages, hover, completions, code lenses...
Note that this slows down the whole webpack build by quite a big margin. Especially fresh builds could take minutes more. Maybe another approach could be taken to include the final .wasm binary?
Test Plan
These changes have been tried manually by just trying stuff out in the hello-world rust demo.
Some parts work a bit less well than on the original rust-analyzer WASM demo because the monaco editor seems to be outdated. This could be fixed in a follow-up PR, as it might need some bigger changes throughout the codebase.
Screenshots/Videos (OPTIONAL)
example of find usages:
ra-lsp-wasm-studio