-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
fix(types): backport fix for withDefaults when used together with generics
#13223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
francis-switcho
wants to merge
1
commit into
vuejs:main
from
francis-switcho:backport-fix-for-generics-usage
Open
fix(types): backport fix for withDefaults when used together with generics
#13223
francis-switcho
wants to merge
1
commit into
vuejs:main
from
francis-switcho:backport-fix-for-generics-usage
+72
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@francis-switcho
francis-switcho
force-pushed
the
backport-fix-for-generics-usage
branch
from
November 8, 2024 19:10
a56d621 to
f6aea2f
Compare
@francis-switcho
francis-switcho
changed the title
(削除) fix(types): backport fix from https://github.com/vuejs/core/pull/8335 (削除ここまで)
(追記) fix(types): backport fix for Nov 8, 2024
withDefaults when used together with generics (追記ここまで)
@francis-switcho
francis-switcho
marked this pull request as ready for review
November 9, 2024 18:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What kind of change does this PR introduce?
Does this PR introduce a breaking change? (check one)
There's a potential breaking change: defaults using a generic type must be declared via
() => Tinstead ofTeven if they're primitive types.The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)Other information:
This PR is nothing but a backport of vuejs/core#8335 by @pikax to the Vue 2 codebase, fixing support for generics when using the
withDefaultshelper since we're relying on it to ease our migration from Vue 2 to Vue 3. I take no merit whatsoever besides taking the time to apply it to the Vue 2 codebase and test if it works.Please let me know if it can be merged!