-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
fix(core - patch):when before patch: old keys like [a, b, c ...] new ... #13112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...keys like [d, b, b, e, ....], when patch the second key "b" Vnode by new children, the vnodeToMove will be undefined, so need add a condition for vnodeToMove fix an error when diff patch, when before patch: old keys like [a, b, c ...] new keys like [d, b, b, e, ....], when patch the second key "b" Vnode by new children, the vnodeToMove will be undefined, so need add a condition for vnodeToMove
// PatchChild.vue <template> <div> {{ data.key }} </div> </template> <script> export default { props: { data: { type: Object, required: true, }, }, }; </script>
// Wrapper.vue <template> <div> <div> <PatchChild v-for="item in list" :key="item.key" :data="item" /> </div> <div><button @click="changeList">changeList</button></div> </div> </template> <script> import PatchChild from './PatchChild.vue'; export default { components: { PatchChild, }, data() { return { list: [ { key: 'A', }, { key: 'B', }, { key: 'C', }, ], }; }, methods: { changeList() { this.list = [ { key: 'D', }, { key: 'B', }, { key: 'B', }, { key: 'E', }, ]; }, }, }; </script>
Keys cannot be repeated. Normally there is already an error for this but this shouldn’t be « fixed ». It’s supposed not to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
...keys like [d, b, b, e, ....], when patch the second key "b" Vnode by new children, the vnodeToMove will be undefined, so need add a condition for vnodeToMove
fix an error when diff patch, when before patch: old keys like [a, b, c ...] new keys like [d, b, b, e, ....], when patch the second key "b" Vnode by new children, the vnodeToMove will be undefined, so need add a condition for vnodeToMove
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: