Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Cypress plugin stop error #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iriadp wants to merge 2 commits into vuejs:dev
base: dev
Choose a base branch
Loading
from iriadp:fix_cypress_stop_error

Conversation

Copy link

@iriadp iriadp commented Sep 5, 2022
edited
Loading

When running tests with cypress plugin and Cypress 10, an exception is thrown when the stop() function is called to stop the server.
Changing method to close() doesn't throw any exception or warning and the server gets closed correctly.
#7230

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Iria Díaz Pérez and others added 2 commits September 5, 2022 10:07
Copy link

@iriadp Thanks for your work!

lucasportolima reacted with thumbs up emoji

Copy link

hey guys, any news about the new build of this fix ?

Copy link

Hi guys, any news about it?

Copy link

yrollam commented Oct 4, 2022

This is blocking out org from upgrading to cypress 10. Would we awesome if this fix got some attention.

Copy link

Any update on when this could be fixed?
This is also blocking our company to upgrade to version 10

Copy link

@yifaneye is there any timeline for this bug fix?

Copy link

@AlbinSahlbom We've been waiting for this as well for several months. Gave up and switched to vite and it was surprisingly painless. Now we're on cypress 12 and as a bonus a much faster dev/build experience.

Copy link

@iriadp can you request reviewers with write accesss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lucasportolima lucasportolima lucasportolima approved these changes

@SimonB-Bell SimonB-Bell SimonB-Bell approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /