-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: lint more files #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint more files #2470
Conversation
✅ Deploy Preview for vue-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 94.89%. Comparing base (
3753ede) to head (0c6ccaa).
Report is 16 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #2470 +/- ## ======================================= Coverage 94.89% 94.89% ======================================= Files 34 34 Lines 2998 2998 Branches 845 845 ======================================= Hits 2845 2845 Misses 150 150 Partials 3 3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@posva
posva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There are several files that aren't currently being formatted by Prettier. I've tried to expand that to include more files.
mjsandmtsextensions.*.htmltolint-staged.lint:scriptto cover more files inpackages, as well asscripts.Changing the paths in
lint:scriptis probably the trickiest part. It's not entirely clear to me whether I've got those paths correct.It's worth noting that
lint-stageddoesn't take those paths into account, it just formats anything with the appropriate extensions. However, it only formats staged files, so anything in.gitignoreis implicitly ignored bylint-staged.Prettier 3 does take the root
.gitignoreinto account, but it doesn't consider nested.gitignorefiles, which are being used in this project. I needed to add the VitePress cache to.prettierignoreto account for that. Perhaps other files should be added too, but it wasn't clear to me what some of the things in the nested.gitignorefiles were.There are also 3 VitePress config files in this PR with minor formatting tweaks. These are files that are now picked up by
lint:scriptthat weren't previously. They should have already been picked up bylint-staged, but prior to #2466 that wasn't working for most people.