-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(types): normalized Query can have undefined properties #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a query param is not present the query value is `undefined`, but the type is only `string | null`. Here is the extract of code where I had this problem: ``` const route = useRoute(); const sortBy = ref(route.query.sort_by.toString()) ``` I got `Cannot read property 'toString' of undefined` but the linter didn't give any errors.
✅ Deploy Preview for vue-router canceled.
|
@posva
posva
changed the title
(削除) Fix LocationQuery type (削除ここまで)
(追記) fix(types): Normalized Query can have undefined properties (追記ここまで)
Aug 10, 2022
@posva
posva
changed the title
(削除) fix(types): Normalized Query can have undefined properties (削除ここまで)
(追記) fix(types): normalized Query can have undefined properties (追記ここまで)
Aug 10, 2022
posva
posva
requested changes
Aug 10, 2022
Member
@posva
posva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this would indeed be better. Can you add a d-ts test and make sure others pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query param is not present the query value is
undefined, but the type is onlystring | null.Here is the extract of code where I had this problem:
I got
Cannot read property 'toString' of undefinedbut the linter didn't give any errors.