Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

⭐️New: Add vue/no-static-inline-styles rule #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ota-meshi merged 3 commits into master from add-rule/no-static-inline-styles
Dec 26, 2019

Conversation

Copy link
Member

@ota-meshi ota-meshi commented Feb 28, 2019

This PR adds the vue/no-static-inline-styles rule.
vue/no-static-inline-styles rule reports the static inline style given to the element.

We recommend moving the reported inline styles to the <style> element.


Close #826

sqal and cjpearson reacted with thumbs up emoji
@ota-meshi ota-meshi force-pushed the add-rule/no-static-inline-styles branch from 1d966df to 6483687 Compare February 28, 2019 14:52
Copy link

cde06 commented Feb 28, 2019

Thank you so much for this PR!!
I hope it will be release soon.

ota-meshi reacted with thumbs up emoji

}
if (!context.options[0] || !context.options[0].allowBinding) {
visitor[
"VAttribute[directive=true][key.name.name='bind'][key.argument.name='style']"
Copy link
Contributor

@privatenumber privatenumber Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be [key.name='bind'][key.argument='style'] ?

Copy link
Member

@mysticatea mysticatea Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #807, AST has been changed a bit to support dynamic argument.

Copy link
Contributor

@privatenumber privatenumber Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah of course. Thank you for the explanation.

@ota-meshi ota-meshi self-assigned this Apr 2, 2019
Copy link

cde06 commented Sep 6, 2019

Hello,
Can we release this fix or are we waiting something else?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@privatenumber privatenumber privatenumber left review comments

@mysticatea mysticatea mysticatea left review comments

Reviewers whose approvals may not affect merge requirements
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: vue/no-inline-styles

AltStyle によって変換されたページ (->オリジナル) /