-
-
Notifications
You must be signed in to change notification settings - Fork 696
Chore: move component-name-in-template-casing rule to uncategorized #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mysticatea i'm unsure if its not better to go for #714 with registeredComponentsOnly set to true by default
I still want to move it to uncategorized because it needs additional configuration for people which use popular libraries.
@mysticatea
mysticatea
deleted the
move-component-name-in-template-casing
branch
December 30, 2018 03:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
component-name-in-template-casingto uncategorized fromstrongly-recommendedcategory.There are some reasons:
x-elementWeb Component, the rule breaks it. To avoid this broken, the user needs to configureignoresoption. Therefore, this rule doesn't fitvue/strongly-recommendedpreset.vue/component-name-in-template-casing#397 (comment) , ⭐️New: Addvue/component-name-in-template-casing#397 (comment) , Beta 5 brakes linter #691 (comment) , and Beta 5 brakes linter #691 (comment) . Users which use kebab-casing is much and our style guide allows it.