-
-
Notifications
You must be signed in to change notification settings - Fork 696
chore: Fix typo in comments #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since we're still in beta v5 I'm going to revert PR with match-component-file-name
(cc @ota-meshi), and merge it once we complete docs and release V5 officially - let's not merge any more rules until then. Could you then leave only typo fixes in this PR @armano2 ?
939267a
to
68cc09b
Compare
match-component-file-name
and fix typos in comments (削除ここまで)@michalsnik done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whaat happened here 🙈 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no clue but editor was screaming at me on this file xd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catches
No description provided.