-
-
Notifications
You must be signed in to change notification settings - Fork 697
Fix: ignore preformatted tokens in html-indent
#659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I thought about fixing with few changes, but because I could not solve the problem of become invalid with other patterns, I solved it with logic of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
@mysticatea can you re-check pls? :)
I will take a look. Thank you for the ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All concerns I had are resolved.
LGTM, thank you so much!
Just I have found, <textarea> has the same matter as <pre>.
Do I need to change the processing of <textarea> with this PR?
Probably, separated PR is better.
I will merge this PR.
@mysticatea Thank you for merged this PR!
I will begin the work related to <textarea> after #676 has been merged.
Uh oh!
There was an error while loading. Please reload this page.
This PR is for fix the issue #653.
I stored tokens in the
<pre>element, and excluded those tokens from validation.--
Fixed #653
The cause of this issue was due to side effects of #503.