Fix: upgrade vue-eslint-parser #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mysticatea merged 2 commits into master from fix-self-closing

Jun 18, 2017

Merged

Fix: upgrade vue-eslint-parser #34

mysticatea merged 2 commits into master from fix-self-closing

Jun 18, 2017

Conversation

mysticatea

Copy link

Member

@mysticatea mysticatea commented Jun 18, 2017

This upgrading will solve 2 problems.

Ensure making correct ASTs about self-closing elements (fixes Self closing elements break v-if rules #29 ). The first impression was difficult, but actually this was easy. (diff: vuejs/vue-eslint-parser@b954bee)
Improve the integration with eslint-plugin-import (refs Compatibility with ESLint 4 #21 (comment) ). I avoid that error as I use parser.parseForESLint() alias. (diff: vuejs/vue-eslint-parser@62acbe8)

Additionally, I added some tests about above.

@mysticatea


 Fix: upgrade vue-eslint-parser

e82bcfd

- Make correct ASTs about self-closing elements (fixes #29)
- Improve the integration with eslint-plugin-import (refs #21)

@mysticatea mysticatea requested a review from michalsnik

June 18, 2017 11:34

michalsnik

michalsnik approved these changes

Jun 18, 2017

View reviewed changes

@michalsnik

Copy link

Member

michalsnik commented Jun 18, 2017

Good work @mysticatea. I didn't know about parseForESLint, seems like a decent solution. Btw. pretty clever way of testing this integration, not so obvious at first sight but does the job 👍