-
-
Notifications
You must be signed in to change notification settings - Fork 696
test: add valid example for empty defineEmits
#2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add valid example for empty defineEmits
#2914
Conversation
⚠️ No Changeset found
Latest commit: ce26e0d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
I don't understand, could you please explain in more detail?
I don't understand, could you please explain in more detail?
It just extends the test suite with this special use case. (See linked code part).
Do be fair, I do not know if this is valid in the real world. But the rule allows it.
I am currently working on the implementation of the rule in oxlint.
This test should help to be consistent across different tools.
oxlint will generate their test code from test source code of the plugin.
If you think, this is not helpful as a test case, feel free to close.
I wanted to be sure we do not include inconsistency between both tools.
If you think, this is not helpful as a test case, feel free to close.
I'll close it.
related #11440 https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/valid-define-emits.md Extended the docs and tests to cover (non) empty `defineEmits()` with `export default` of other script block. Related vuejs/eslint-plugin-vue#2914
Covering this part of the code:
eslint-plugin-vue/lib/rules/valid-define-emits.js
Lines 121 to 128 in a198b52
Found in oxc-project/oxc#12545