-
-
Notifications
You must be signed in to change notification settings - Fork 694
Add new vue/prefer-define-component rule
#2738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@absidue
absidue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest reverting all of the formatting changes to the markdown files, as it makes the diff a lot larger than it needs to be, which makes it harder to review.
⚠️ No Changeset found
Latest commit: 7ac6c2c
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link definition is now unused. Please run npm run update to regenerate the docs, then both Markdownlint errors should be fixed.
I noticed it's been about a month since the last update. Are you still planning to address the formatting feedback and add the changeset? If you're busy or would like help moving this forward, I'd be happy to assist 👍
(No pressure at all - just wanted to check in since this would be a valuable addition to the plugin.)
Uh oh!
There was an error while loading. Please reload this page.
This resolves #2661