Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add autofix to vue/prefer-use-template-ref #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thomasan1999 wants to merge 10 commits into vuejs:master
base: master
Choose a base branch
Loading
from Thomasan1999:master

Conversation

Copy link
Contributor

@Thomasan1999 Thomasan1999 commented Nov 30, 2024
edited
Loading

Addresses #2554 (comment)

# Conflicts:
#	docs/rules/index.md
#	tests/lib/rules/prefer-use-template-ref.js
Copy link

changeset-bot bot commented Jun 7, 2025
edited
Loading

🦋 Changeset detected

Latest commit: d201c21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now 🙂
Thanks for your contribution!

Thomasan1999 reacted with heart emoji
@FloEdelmann FloEdelmann changed the title (削除) feat(prefer-use-template-ref): add support for fix option (削除ここまで) (追記) Add autofix to vue/prefer-use-template-ref (追記ここまで) Jun 11, 2025
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks almost good, but I have one comment.

)

if (!missingImportChecked) {
missingImportChecked = true
Copy link
Member

@ota-meshi ota-meshi Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this flag for?
Perhaps to avoid autofix conflicts?
If so, ESLint's autofixes avoid conflicts as much as possible by core, so there's no need to handle that in the rules.

Copy link
Member

@FloEdelmann FloEdelmann Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thomasan1999 it would be great to get this merged. Could you please have a look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi requested changes

@waynzh waynzh Awaiting requested review from waynzh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /