Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix: move index.js and configs #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsnik merged 1 commit into dev from fix-index
Jun 15, 2017
Merged

Fix: move index.js and configs #23

michalsnik merged 1 commit into dev from fix-index
Jun 15, 2017

Conversation

Copy link
Member

@mysticatea mysticatea commented Jun 15, 2017
edited
Loading

It have thrown "Module not found" error when I do require("eslint-plugin-vue") with 3.0.0 because the package.json has main: "lib/index.js" field and the lib/index.js does not exist.

This PR moves files:

  • index.jslib/index.js
  • Incidentally, configlib/config because I think that the config directory should exist at the same level as rules directory.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. I thought eslint-generator puts index out of lib directory by default so I moved it. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@michalsnik michalsnik michalsnik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /