Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add new vue/require-prop-comment rule #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
czb3279338858 wants to merge 0 commits into vuejs:master from czb3279338858:master

Conversation

Copy link
Contributor

@czb3279338858 czb3279338858 commented Oct 24, 2022
edited by FloEdelmann
Loading

Fixes #1993

Copy link
Contributor Author

czb3279338858 commented Oct 24, 2022
edited
Loading

npm run update,Changed the description of many files,I'm not sure this is correct, but I still submitted the code

Copy link
Contributor Author

1 failing:The file causing the error is not modified by me. Should I repair it before submitting

@FloEdelmann FloEdelmann changed the title (削除) add require-prop-comment rule (削除ここまで) (追記) Add new vue/require-prop-comment rule (追記ここまで) Oct 24, 2022
Copy link
Contributor Author

Where there is dispute, should I initiate a new merger request? @FloEdelmann

Copy link
Member

You don't need to open a new PR, you can instead push new commits to this branch. Also, rebasing and force-pushing is not required, we will squash the whole branch into one commit on the master branch when merging the PR.

Copy link
Contributor Author

@FloEdelmann I push new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-prop-comment

AltStyle によって変換されたページ (->オリジナル) /