Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve warning wording in vue/no-v-for-template-key docs #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FloEdelmann merged 2 commits into vuejs:master from yammyxing:patch-1
Apr 22, 2022

Conversation

Copy link
Contributor

@yammyxing yammyxing commented Apr 21, 2022

fix the warning note on rule conflicts between vue/no-v-for-template-key and vue/no-v-for-template-key-on-child

fix the warning note on rule conflicts between vue/no-v-for-template-key and vue/no-v-for-template-key-on-child
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original note is correct.
However, I am not familiar with English, so I may have misunderstood.
Could you give me the details on this fix?

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ota-meshi, the previous note was correct. But it was difficult to understand, so here is my approach to clear that up. See also the similar #1859 (comment)

ota-meshi and yammyxing reacted with thumbs up emoji
Copy link
Contributor Author

ok, the approach is clear enough.

Copy link
Contributor Author

I think the original note is correct. However, I am not familiar with English, so I may have misunderstood. Could you give me the details on this fix?

seems like i get the meaning of 'use with' wrong, my bad [Lol]

@FloEdelmann FloEdelmann changed the title (削除) docs: fix the warning note (削除ここまで) (追記) Improve warning wording in vue/no-v-for-template-key docs (追記ここまで) Apr 22, 2022
@FloEdelmann FloEdelmann merged commit 849e969 into vuejs:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi requested changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /