-
-
Notifications
You must be signed in to change notification settings - Fork 696
Add vue/padding-line-between-component-options rule
#1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vue/padding-line-between-component-options rule
#1818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice rule proposal and implementation! I have just a few small remarks 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side! 🙂
empty-line-between-options (削除ここまで)vue/padding-line-between-component-options rule (追記ここまで)
I wrote a comment.
#1817 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current state, this PR looks fine (apart from one typo).
However, as discussed in the corresponding issue (#1817), the rule has currently many overlaps with new-line-between-multi-line-property. So the suggestions from the issue need to be incorporated. This can either be done in this PR or a new clean one.
@barthy-koeln I'll close this for now. If you or anyone else finds the time to implement the new suggestions in #1817, feel free to submit a new pull request!
Code for suggestion at #1817.