Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(vite): fix inspector short key failure #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wzc520pyfm wants to merge 1 commit into vuejs:main
base: main
Choose a base branch
Loading
from wzc520pyfm:fix/vue-inspector-toggle-combo-key

Conversation

@wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Aug 3, 2024
edited
Loading

hi~, I am working on #547 , but I found vite-plugin-vue-inspector's toggleComboKey was set to '', this makes the default shortcut key for opening the inspector invalid.
When I removed it, vite-plugin-vue-inspector's toggleComboKey is working!

After this pr, I plan to add this default shortcut key for inspector to the documentation, as well as how to customize the option of vite-plugin-vue-inspector.

J-Sek reacted with thumbs up emoji
Copy link

netlify bot commented Aug 3, 2024
edited
Loading

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 5d2d730
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66ade002591aec000834fa60

Copy link
Member

Probably users can configure the combo key by passing some options like the docs say.

Copy link
Contributor Author

Probably users can configure the combo key by passing some options like the docs say.

I agree, users can customize shortcuts by passing a config, but perhaps we should provide default shortcuts as well?

Copy link
Member

How about implementing the user-defined toggle combo key in this PR?

Copy link
Contributor Author

How about implementing the user-defined toggle combo key in this PR?

I wrote the custom shortcut documentation in #559. The user can do this by passing Options.componentInspector.toggleComboKey to vuedevtoolnext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /