Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add vue-i18n support (fixes #545) #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Lingchen111 wants to merge 2 commits into vuejs:main
base: main
Choose a base branch
Loading
from Lingchen111:feature/issue-545

Conversation

Copy link

@Lingchen111 Lingchen111 commented Jun 29, 2025

This PR adds vue-i18n support to create-vue templates, including:

  • Basic i18n configuration setup
  • Snapshot tests for i18n functionality
  • Resolves the template integration difficulties mentioned in i18n vue plugin option ? #545

Implementation references the approach from closed PR #548

Copy link
Author

Regarding CI Test Failures
Dear reviewers,
This PR currently fails CI checks due to the following issues:

Missing updates to codeTemplate in index.ts
Absence of some required files

I will promptly address these by:

1.Synchronizing all template index references
2.Adding missing configuration files
3.Re-running full test suites

If you identify any additional issues or have optimization suggestions during review, please don’t hesitate to point them out. Your guidance would be greatly appreciated!
Thank you for your time and consideration.

Copy link
Collaborator

btea commented Jun 30, 2025
edited
Loading

package-lock.json does not need to be commit. Please resolve the code conflicts.

Lingchen111 reacted with thumbs up emoji

Copy link
Author

Lingchen111 commented Jul 1, 2025
edited
Loading

package-lock.json does not need to be commit. Please resolve the code conflicts.

Thank you for pointing that out! I appreciate your feedback, and I’ll make sure to remove the package-lock.json in the next commit.

@Lingchen111 Lingchen111 marked this pull request as draft July 2, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /