Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[feat] Added support for Bun #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mchao123 wants to merge 4 commits into vuejs:main
base: main
Choose a base branch
Loading
from mchao123:main
Open

[feat] Added support for Bun #630

mchao123 wants to merge 4 commits into vuejs:main from mchao123:main

Conversation

Copy link

@mchao123 mchao123 commented Dec 5, 2024

Added support for Bun, added runtime selectors.

This is a tentative change that may require a review of the code.

Copy link
Member

@mchao123 Thanks for the PR

@haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?).

Copy link
Member

@haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?).

I'm open to add bun support considering it's low-effort. But I don't think we need yet another option to show to every user. User-agent detection should suffice.

Copy link
Author

@haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?).

I'm open to add bun support considering it's low-effort. But I don't think we need yet another option to show to every user. User-agent detection should suffice.

Some people prefer to use yarn or pnpm to manage their project creation.

Copy link
Member

Some people prefer to use yarn or pnpm to manage their project creation.

But I don’t think that’s a common enough use case for us to support.

Copy link
Author

mchao123 commented Feb 6, 2025

It's been a long time has there been an update on this?I always need to do some extra work after creating a project in order to adapt to bun, it would be great if this was supported at creation time, thank you guys.

Copy link
Member

@mchao123 I think the user-agent detection proposition from @haoqunjiang is a good one: not too much maintenance work, and not another prompt for users. Feel free to ping us when you'll have reworked the PR 👍

mchao123 reacted with rocket emoji

Copy link
Author

mchao123 commented Feb 6, 2025

@mchao123 I think the user-agent detection proposition from @haoqunjiang is a good one: not too much maintenance work, and not another prompt for users. Feel free to ping us when you'll have reworked the PR 👍

Ok, I'll close this PR and finish this modification based on the latest branch again.

Copy link
Author

mchao123 commented Feb 6, 2025

I've made the change to show the runtime checkbox only when the user carries the parameter "--runtime".Maintaining a proprietary version of a package only requires creating a new directory in the others-runtime folder.

Copy link
Author

我认为 user-agent detection 的提议很好:没有太多的维护工作,也没有_给用户另一个_提示。当您重新编写 PR 👍 时,请随时 ping 我们

Help reviewing the code, thanks! @cexbrayat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /