-
Notifications
You must be signed in to change notification settings - Fork 496
feat: eslint plugin playwright #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eslint plugin playwright #433
Conversation
Nice one @georgi-mateev
Could you guys provide us with feedback @sodatea @cexbrayat
utils/renderEslint.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the plugin apply only the Playwright files (as done for Cypress above)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ESLint will apply the rules defined in the root of your configuration to all files in your project (which is not ideal).
@georgi-mateev Can you target e2e folder - something like files: ['e2e/**/*.{js,ts,jsx,tsx}']?
@cexbrayat, @Yordan-Ramchev Thanks for the feedback and the help, appreciate it!
Changes
Plugin now only applies to specified files -
eslint-plugin
Regarding files we think its versatile enough to target files having either .test. or .spec. signature both in the the main folder and its subfolders, if any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @georgi-mateev 👍
Re #422
"extends": ["plugin:playwright/recommended"]