-
Notifications
You must be signed in to change notification settings - Fork 496
Update deps for Vue 2.7 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should merge like this, so we'll have to wait for the fix (but it may take a long time as VTU v1 is not really active).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, you're right.
Because there are still lists left to complete.
so we'll have to wait for the fix ......
For that matter, the problem actually existed before I modified this project.
I'm also wondering how he (Haoqun Jiang) avoided this problem, after all, the last version already depends on Vue 2.7.x already!
How about we ask "Haoqun Jiang" for advice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I have no idea how to fix that type error...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A workaround was proposed in the issue I opened previously: vuejs/vue-test-utils#2026 (comment)
But I'm no expert on TypeScript, so I don't know if that's the right fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH.
It would be best to have vue-test-utils aligned with "Vue 2.7.16".
But that repository is not very active.
I've also forked vue-test-utils aligned to try to fix this, which is a bit of a challenge.
A more practical solution for now is to create a corresponding Typescript shim in the output template,like vuejs/vue-test-utils#2026 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cexbrayat Hi!
Excuse me!
Could you please review the latest submission and provide feedback on whether it is an acceptable solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine by me. Obviously it would be better to open a PR on VTU to fix it properly and get a new release, but I'm not sure many people will generate a new Vue 2 project with create-vue, so that's probably OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously it would be better to open a PR on VTU to fix it properly and get a new
release,
Since the VTU author is currently focusing on "Vue 3", I can follow up in the future when this issue is fixed.
Possibly (vuejs/vue-test-utils#2087 (comment)) I'll open a PR
For now. I think this solution is sufficient
(削除) waiting (削除ここまで) merged cypress-io/cypress#28818
@sodatea!
Excuse me🤗
Can you look look this vuejs/create-vue-templates#3
9ec126d to
5a02fc8
Compare
6b89f19 to
4b6358b
Compare
Hi everyone. Long time no see!
It looks like the master plan is complete. Would you mind reviewing it?
954afa7 to
a79b411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it, but LGTM at first glance.
I think we should also deprecate this version of create-vue as Vue 2 is now EOL to discourage its usage.
I haven't tested it, but LGTM at first glance.
I have executed the test script and he passed all of it
I think we should also deprecate this version of create-vue as Vue 2 is now EOL to discourage its usage.
let's we try npm-deprecate
@marcosdissotti
marcosdissotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Uh oh!
There was an error while loading. Please reload this page.
closed: #408 #185
TODO List
Output Template
pnpmto v8vueto v2.7.16nodeto 18+viteto v5typescriptto v5cypressto v13vitestto v1@vue/test-utils@v1work with v2.7.16@cypress/vue2work with v2.7.16Self