-
Notifications
You must be signed in to change notification settings - Fork 497
chore: explicitly set tsBuildInfoFile in tsconfig.*.json files #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To avoid polluting the root directory with tsconfig.*.tsbuildinfo files. `outDir` in the base config doesn't work because of vuejs/tsconfig#27 (comment) Besides, we need this explicit config in `tsconfig.node.json` anyways, as it doesn't extend from `@vue/tsconfig`. Using `.tmp` instead of `.cache` here to better indicate the purpose.
bmulholland
commented
Dec 20, 2023
Is it worth adding comments to explain what the lines in tsconfig are doing and why?
I thought the option name and the path were self-explanatory enough?
and why
That's worth adding to every option in tsconfig files, though. Let's do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: empty line should be remove? Here and in other configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to distinguish the emitting-related options from other options... The empty lines would make more sense once we add more detailed explanations in the configs.
segevfiner
commented
Feb 4, 2024
@sodatea Just wondering, what's the reason for removing noEmit from those tsconfig.json files?
codethief
commented
Jul 25, 2024
@segevfiner I suppose because TSC project references require emitting declarations, compare my comment here.
@sodatea Just wondering, what's the reason for removing
noEmitfrom thosetsconfig.jsonfiles?
😅 I ran into the same question when reviewing my own code... I should've left more comments in the commit...
It's because noEmit: true is turned on by default in @vue/tsconfig: https://github.com/vuejs/tsconfig/blob/480cd96cfeea29125c72d7e31fc18b3cbf11b93f/tsconfig.json#L3-L5
So, I removed it from the project template to reduce the user-facing configuration options.
To avoid polluting the root directory with tsconfig.*.tsbuildinfo files.
outDirin the base config doesn't work because of vuejs/tsconfig#27 (comment) Besides, we need this explicit config intsconfig.node.jsonanyways, as it doesn't extend from@vue/tsconfig.Using
.tmpinstead of.cachehere to better indicate the purpose.