Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Correct the 'build' command in the package.json file. #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mishengqiang wants to merge 1 commit into vuejs:main
base: main
Choose a base branch
Loading
from mishengqiang:patch-1

Conversation

Copy link

@mishengqiang mishengqiang commented Nov 30, 2023
edited
Loading

The package.json file is located at template/config/typescript/package.json.

run-p type-check \"build-only {@}\" -- -> run-p type-check \"build-only -- {@}\" --

#393

The package.json file is located at template/config/typescript/package.json.
@mishengqiang mishengqiang changed the title (削除) Correct the 'build' command in the package.json file. (削除ここまで) (追記) fix: Correct the 'build' command in the package.json file. (追記ここまで) Nov 30, 2023
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes commands like npm run build -- --sourcemap, but it no longer works with pnpm run build --sourcemap because it adds an extra --

@sodatea WDYT?

marcosdissotti reacted with thumbs up emoji
Copy link
Author

Ah, I didn't consider pnpm and yarn. After testing, yarn performs the best – it passes parameters as expected regardless of whether -- is added or not. npm requires an extra -- to pass parameters as expected. pnpm doesn't need an extra -- to pass parameters as expected.

image

The image below demonstrates when an extra '--' is added.
image

Copy link
Member

Yes, that's why I don't know if we should change the default or not, or maybe there is a way to make it work with all package managers?

Copy link
Member

Yeah, I think this should be resolved in the upstream npm-run-all2 package instead.
Before that, maybe we can add a note in the generated README?

Copy link

Yeah, I think this should be resolved in the upstream npm-run-all2 package instead. Before that, maybe we can add a note in the generated README?

I resolved it in the bcomnes/npm-run-all2#143.

We can run run-p type-check \"build-only -- {@}\" -- on npm/yarn/pnpm when the PR is merged

Yordan-Ramchev reacted with heart emoji

Copy link

ayu-exorcist commented Jul 4, 2024
edited
Loading

Yeah, I think this should be resolved in the upstream npm-run-all2 package instead. Before that, maybe we can add a note in the generated README?

I resolved it in the bcomnes/npm-run-all2#143.

We can run run-p type-check \"build-only -- {@}\" -- on npm/yarn/pnpm when the PR is merged

Already merged in npm-run-all2 v6.2.1

We can try to merge this PR now!

Copy link

bcomnes commented Jul 4, 2024

Turns out this was a breaking change so I reverted. I need to consider this change a little bit more and at a minimum, put it out in a major release with notes on upgrading.

ayu-exorcist and messenjer reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat left review comments

@haoqunjiang haoqunjiang Awaiting requested review from haoqunjiang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /