Skip to content

fix: use vite dev during e2e dev #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Akryum wants to merge 2 commits into vuejs:main from Akryum:patch-1

Closed

fix: use vite dev during e2e dev #39

Akryum wants to merge 2 commits into vuejs:main from Akryum:patch-1

Conversation

Akryum

Copy link

Member

@Akryum Akryum commented Jan 24, 2022

No description provided.

Akryum added 2 commits

January 24, 2022 12:17


 fix: use vite dev during e2e dev

e8492c8


 feat: update generate readme

f277d16

Copy link

Member

haoqunjiang commented Jan 25, 2022

This makes some sense as all browsers that Cypress supports are modern browsers.
🤔 But on the other hand, unlike webpack, vite dev and vite build outputs differ greatly. Unit tests can't cover these differences.
So I would prefer to use E2E tests to make sure the build works correctly. Speed isn't much of a concern here.

@haoqunjiang haoqunjiang mentioned this pull request

refactor!: use prod bundle & preview server for playwright testing on CI #182

Merged

Copy link

Member

haoqunjiang commented Oct 21, 2022

Superseded by #183
We now have a test:e2e:dev command to use the dev server and run the tests interactively.

@haoqunjiang haoqunjiang closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment